refactor: simplify mr blobby v2 abstractions #27896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pl
changed the title
benjackwhite
approved these changes
Jan 27, 2025
timgl
pushed a commit
that referenced
this pull request
Jan 28, 2025
adamleithp
pushed a commit
that referenced
this pull request
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After the feedback from code reviews this week, it was clear that the code would be more readable for the team if some indirections were removed. Initially, I added the abstractions to make it easier to isolate the test dependencies, but Jest provides an API for mocking modules, so the indirections were not necessary to isolate the dependencies for testing.
Changes
I inlined several constructor invocations to make the code more linear to read.
I also moved the tests to be alongside the implementation files.
Does this work well for both Cloud and self-hosted?
Yest
How did you test this code?
Unit tests.