Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(flox): Upgrade mprocs for new features #27898

Merged
merged 1 commit into from
Jan 27, 2025
Merged

chore(flox): Upgrade mprocs for new features #27898

merged 1 commit into from
Jan 27, 2025

Conversation

Twixes
Copy link
Member

@Twixes Twixes commented Jan 26, 2025 •
edited
Loading

Changes

Upgrading mprocs in manifest.toml from 0.7.1 to 0.7.2 to get pvolok/mprocs#155 in, along with a couple other improvements.

rafaeelaudibert
rafaeelaudibert reviewed Jan 27, 2025
View reviewed changes
Copy link
Member

@rafaeelaudibert rafaeelaudibert left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not using flox myself, so will remove the request for review, sorry 🥺

@Twixes Twixes requested a review from mariusandra January 27, 2025 09:54
andehen
andehen approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@andehen andehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement to mprocs @Twixes! 👍

My flox env worked just as expected, no issues encountered.

@Twixes Twixes merged commit 0a9db49 into master Jan 27, 2025
95 checks passed
@Twixes Twixes deleted the mprocs-hide-help branch January 27, 2025 16:52
timgl pushed a commit that referenced this pull request Jan 28, 2025
@Twixes @timgl
chore(flox): Upgrade mprocs for new features (#27898)
91b8fae
adamleithp pushed a commit that referenced this pull request Jan 29, 2025
@Twixes @adamleithp
chore(flox): Upgrade mprocs for new features (#27898)
d6b8c38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaeelaudibert rafaeelaudibert rafaeelaudibert left review comments

@andehen andehen andehen approved these changes

@mariusandra mariusandra Awaiting requested review from mariusandra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Twixes @andehen @rafaeelaudibert