feat(batch-exports): Support for event property filters #27921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Making a draft while I fix some conflicts, some test failures, and address an issue with the UI. |
tomasfarias
force-pushed
the
feat/property-filters-for-batch-exports
branch
from
3ee4a41 to
3a662da
Compare
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
|
Size Change: 0 B Total Size: 1.16 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
tomasfarias
force-pushed
the
feat/property-filters-for-batch-exports
branch
from
3ea4b04 to
cc6de9c
Compare
rossgray
reviewed
Jan 28, 2025
posthog/temporal/tests/batch_exports/test_s3_batch_export_workflow.py
Outdated
Show resolved
Hide resolved
tomasfarias
force-pushed
the
feat/property-filters-for-batch-exports
branch
from
ed22b04 to
e56c7c5
Compare
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
adamleithp
pushed a commit
that referenced
this pull request
Jan 29, 2025
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As described in #26415, users wish to filter batch exports using properties. This is currently not supported by batch exports, so this PR adds support for it. See breakdown of all changes.
Changes
Backend
BatchExportModelnow accepts serialized HogQL event property filters in a new attributefilters.filtersare now parsed to a clickhouse expression when initializing the record batch producer (as a consequence,Producer.startis now async).events_batch_export_*views are no longer in use.Frontend
PropertyFiltercomponent.exclude_eventsandinclude_events.TODO
Only event properties can be used in filters. A follow-up PR will expand this for person properties too.
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?
Added a new model to S3 tests that has property filters. UI stuff tested manually.