feat: add a survey to opt out SR #27949
Conversation
| surveyId: string | ||
| } | ||
|
|
||
| export const InternalMultipleChoiceSurveyLogic = kea<InternalMultipleChoiceSurveyLogicType>([ |
There was a problem hiding this comment.
nit, we tend to lower camel case these... so internalMultipleChoiceSurveyLogic
| setThankYouMessage: (thankYouMessage: string) => ({ thankYouMessage }), | ||
| }), | ||
| reducers({ | ||
| surveyId: [ |
There was a problem hiding this comment.
what's the use case for varying the survey id past the one specified in props?
since we're keyed on survey id in props i think this shouldn't change?
There was a problem hiding this comment.
I think I see why you're using this and included what to do instead - hope that makes sense :)
| })), | ||
| afterMount(({ actions, props }) => { | ||
| /** When the logic is mounted, set the surveyId from the props */ | ||
| actions.setSurveyId(props.surveyId) |
There was a problem hiding this comment.
ah... you can read props in variious places so don't need that...
let me re-read this...
| @@ -316,6 +316,7 @@ export const SESSION_REPLAY_MINIMUM_DURATION_OPTIONS: LemonSelectOptions<number | |||
| ] | |||
|
|
|||
| export const UNSUBSCRIBE_SURVEY_ID = '018b6e13-590c-0000-decb-c727a2b3f462' | |||
| export const SESSION_RECORDING_OPT_OUT_SURVEY_ID = '0194a763-9a13-0000-8088-32b52acf7156' | |||
There was a problem hiding this comment.
we could do this as a flag payload so we can change the survey without a code release but that's very nit-picky
| listeners(({ actions, values }) => ({ | ||
| /** When surveyId is set, get the list of surveys for the user */ | ||
| setSurveyId: () => { | ||
| posthog.getSurveys(actions.handleSurveys) |
There was a problem hiding this comment.
so you can call this in the afterMount instead of calling setSurveyId in it
| }, | ||
| /** Callback for the surveys response. Filter it to the surveyId and set the survey */ | ||
| handleSurveys: ({ surveys }) => { | ||
| const survey = surveys.find((s: PostHogSurvey) => s.id === values.surveyId) |
There was a problem hiding this comment.
then this would be props.surveyId
| }, | ||
| ], | ||
| }), | ||
| listeners(({ actions, values }) => ({ |
There was a problem hiding this comment.
you'd add props here alongside actions, values
| /** When surveyId is set, get the list of surveys for the user */ | ||
| setSurveyId: () => {}, |
There was a problem hiding this comment.
| /** When surveyId is set, get the list of surveys for the user */ | |
| setSurveyId: () => {}, |
i think we can remove entirely?
|
Size Change: -113 B (-0.01%) Total Size: 1.16 MB ℹ️ View Unchanged
|
We want to show a survey when customers turn off Session Replay to collect the data why people churn.