feat: add metrics to livestream server #27953
Merged
+214
−139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, fix very unlikely event of not being able to write and not closing the subscription.
Daesgar
approved these changes
Jan 28, 2025
adamleithp
pushed a commit
that referenced
this pull request
Jan 29, 2025
adamleithp
pushed a commit
that referenced
this pull request
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Our livestream server is observable only through a proxy metrics (e.g. http traffic metrics).
Changes
Add prometheus handler and metrics.
Hide non-production endpoints, don't print debug in production.
Add a little documentation.
Does this work well for both Cloud and self-hosted?
Yes.
How did you test this code?
Run it in docker