Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Plugin Hog function migrator #27958

Merged
merged 5 commits into from
Jan 28, 2025
Merged

fix: Plugin Hog function migrator #27958

merged 5 commits into from
Jan 28, 2025

Conversation

benjackwhite
Copy link
Contributor

Problem

  • Tried this out and immediately crashed hard due to OOM
  • Also noticed that some legacy plugins have orgs without the required addon so we need to bypass this logic to get it to work

Changes

  • Reworks the migration script to be loading as little info as possible
  • Logs out teams in this special case without the addon
  • Corrects some of the ways fields were loaded

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@benjackwhite benjackwhite requested a review from a team January 28, 2025 13:41
@posthog-bot
Copy link
Contributor

Hey @benjackwhite! 👋
This pull request seems to contain no description. Please add useful context, rationale, and/or any other information that will help make sense of this change now and in the distant Mars-based future.

Copy link

sentry-io bot commented Jan 28, 2025

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: posthog/cdp/migrations.py

Function Unhandled Issue
migrate_legacy_plugins ValidationError: {"inputs":{"googleCloudKeyJson":"Value must be a string."}} posthog.cdp.migratio...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

posthog/cdp/migrations.py Dismissed Show dismissed Hide dismissed
@benjackwhite benjackwhite enabled auto-merge (squash) January 28, 2025 13:55
@benjackwhite benjackwhite merged commit 06f96bb into master Jan 28, 2025
91 of 92 checks passed
@benjackwhite benjackwhite deleted the fix/migration-script branch January 28, 2025 14:40
adamleithp pushed a commit that referenced this pull request Jan 29, 2025
adamleithp pushed a commit that referenced this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants