feat(experiments): add delta timeseries chart UI #27960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +65 B (+0.01%) Total Size: 1.16 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
…PostHog/posthog into experiments-timeseries-chart-ui
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
danielbachhuber
approved these changes
Jan 28, 2025
| @@ -0,0 +1,151 @@ | |||
| import { Chart, ChartConfiguration } from 'chart.js/auto' | |||
There was a problem hiding this comment.
It would be nice to have a storybook for this (at some point in the future) that includes the various permutations of data (zero days, one day, 100 days)
| @@ -401,6 +404,16 @@ export function DeltaChart({ | |||
| }) | |||
| }} | |||
| onMouseLeave={() => setTooltipData(null)} | |||
| onClick={() => { | |||
There was a problem hiding this comment.
It's not intuitive to me that hovering produces one UI and clicking produces another UI. Not a blocker, though.
There was a problem hiding this comment.
Yep, can adjust later 👍
adamleithp
pushed a commit
that referenced
this pull request
Jan 29, 2025
adamleithp
pushed a commit
that referenced
this pull request
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Feature flag:
experiments-interval-timeseriesAdd a chart with dummy data as preparation for #26931. The chart opens when you click on a credible interval bar.
How did you test this code?
👀