chore(data-warehouse): optimize databaseschemaquery #27977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EDsCODE
commented
Jan 28, 2025
|
|
||
| # Fetch warehouse tables with related data in a single query | ||
| warehouse_tables_with_data = ( | ||
| DataWarehouseTable.objects.select_related("credential", "external_data_source") |
There was a problem hiding this comment.
i'm pretty rusty on exactly what django ORM spits out but this should be ultimately better than n+3 queries
Gilbert09
approved these changes
Jan 28, 2025
phixMe
approved these changes
Jan 28, 2025
adamleithp
pushed a commit
that referenced
this pull request
Jan 29, 2025
adamleithp
pushed a commit
that referenced
this pull request
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?