feat: Add more settings and tunability to snapshot table and dictionary #28062
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If
max_memory_usage
is set on the cluster client settings, theINSERT INTO
statement in the populate step can fail due to the large aggregation needed to ensure we have the latest value for each override in the overrides table.Changes
optimize_aggregation_in_order
reduces the memory (which we don't have enough of) at the cost of some time (which we have plenty of.)This also allows providing a
max_memory_usage
parameter to the dictionary as an additional safeguard against excessive memory usage on the cluster during job execution.Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Already covered by existing test, and ensured
optimize_aggregation_in_order
improved the peak memory usage of the relevant query in production