feat(cdp): add uniqueness constraint for hog functions #28074
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and execution_order
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added a uniqueness constraint for hog functions to ensure deterministic execution order within teams, along with comprehensive test coverage.
- Added constraint in
/posthog/migrations/0557_unique_execution_order_per_team_and_type.pyenforcing unique execution_order per team and function type - Added test in
hog-transformer.service.test.tsverifying duplicate execution orders are rejected with appropriate error - Added test validating that functions with null execution_order can coexist and execute last
- Added test confirming functions execute in correct sequential order based on execution_order values
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
benjackwhite
requested changes
Jan 30, 2025
| ("posthog", "0556_add_execution_order_to_hog_functions"), | ||
| ] | ||
|
|
||
| operations = [ |
There was a problem hiding this comment.
Not sure I agree with this tbh. Can we do this after we have actually implemented the ordering logic? Feels like there could be a lot of gotchas otherwise
There was a problem hiding this comment.
sure i'll just leave it open for now. i'm speccing out the changes i need to do for the api and not having duplicated execution_orders was one of the concerns in the spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently we can have multiple transformations for the same team having the same execution_order which would make sorting and function execution non deterministic.
Changes
nullcan exist👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?