chore: remove experiment creation from experiment scenes #28081
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Modified the supportsCreatingExperiment selector in insightLogic.tsx to prevent experiment creation within experiment-related scenes, improving UX by avoiding recursive experiment creation.
- Added scene-based validation in
supportsCreatingExperimentto disable experiment creation inScene.Experiment,Scene.Experiments, and experiment metrics scenes - Maintains existing query validation through
isValidQueryForExperimentcheck - Prevents confusing UX where users could create experiments while already viewing experiment results
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -70,6 +72,8 @@ export const insightLogic: LogicWrapper<insightLogicType> = kea<insightLogicType | |||
| ['user'], | |||
| featureFlagLogic, | |||
| ['featureFlags'], | |||
| sceneLogic, | |||
| ['activeScene'], | |||
There was a problem hiding this comment.
I'm pretty unsure about doing this - we should be fine as the logic is already mounted at the app level but can someone think if this is a bad idea?
Alternatively, we could pass a prop in the insightProps to avoid this.
There was a problem hiding this comment.
Yeah, I don't know really. With a prop, the dependency is more explicit. But can't think of any strong arguments against this. Any similar logic in the code base we should be consistent with? Couldn't find any myself.
There was a problem hiding this comment.
Not really - as I mentioned there is InsightLogicProps but that's more for general properties of the insight. Tests are passing so I'm okay merging this if you can't think of a strong reason not to, and then reverting if it causes a problem, didn't find any issues when running locally.
|
Size Change: -10 B (0%) Total Size: 1.16 MB ℹ️ View Unchanged
|
Problem
We prompt users to create experiments from funnels, but this doesn't make sense if they are already viewing experiment results.
Changes
Hide "create experiment" button based on the currently active scene
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Manually