feat(web-analytics): Move revenue tracking to data management #28087
Conversation
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
robbie-c
force-pushed
the
feature/move-revenue-tracking-to-data-management
branch
from
1c205b7 to
ccfa1a2
Compare
|
Size Change: +44 B (0%) Total Size: 1.16 MB ℹ️ View Unchanged
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR moves revenue tracking from web analytics to data management, improving accessibility and discoverability. Here's a concise summary of the key changes:
- Added new
/data-management/revenueroute and tab in DataManagementScene for revenue tracking configuration - Added
ProductIntroductioncomponent in/frontend/src/scenes/data-management/revenue/RevenueEventsSettings.tsxfor better empty state UX - Critical bug in
/frontend/src/scenes/data-management/revenue/revenueEventsSettingsLogic.tswhereaddEventreducer logic would prevent adding new events - Added settings gear icon in
WebOverview.tsxlinking to revenue configuration for revenue-related metrics - Removed revenue tracking from web analytics settings section in
SettingsMap.tsxfor better organization
The changes improve the feature's accessibility for marketing analytics use cases, but the addEvent reducer bug needs to be addressed before merging.
9 file(s) reviewed, 8 comment(s)
Edit PR Review Bot Settings | Greptile
frontend/src/scenes/data-management/revenue/revenueEventsSettingsLogic.ts
Outdated
Show resolved
Hide resolved
frontend/src/scenes/data-management/revenue/RevenueEventsSettings.tsx
Outdated
Show resolved
Hide resolved
…ngs.tsx Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
| thingName="revenue event" | ||
| description="Revenue events are used to track revenue in Web analytics. You can choose which custom events PostHog should consider as revenue events, and which event property corresponds to the value of the event." | ||
| isEmpty={events.length === 0} | ||
| action={() => buttonRef.current?.click()} |
There was a problem hiding this comment.
It actually feels pretty nice in the UI as well - the taxonomic popover opens upwards so even if you click the ProductIntro's button, your mouse will be over the list of events
Problem
This was hidden in web analytics settings, but if it's going to be used elsewhere (e.g. marketing analytics) then it makes sense for it to be somewhere more common
Changes
In menu bar:
New empty state:
Settings in web analytics
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Ran locally, took screenshots :)