fix(experiments): Fix failing tests #28089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gilbert09
approved these changes
Jan 30, 2025
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR makes a focused change to fix failing tests in the experiment trends query runner by removing two error keys that were previously dropped in PR #27772. Here's a concise summary:
- Removes
NO_EVENTSandNO_FLAG_INFOerror keys from expected errors in test cases - Affects two test methods in
test_experiment_trends_query_runner.py - Aligns test expectations with current error handling behavior
The changes are straightforward maintenance updates to keep tests in sync with the current codebase's error handling approach.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
andehen
approved these changes
Jan 30, 2025
robbie-c
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes tests failing on
master.These keys were dropped in #27772. #27603 wasn't up to date when I merged it.
How did you test this code?
Tests should pass.