Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add all deprecated transformations #28097

Merged
merged 189 commits into from
Feb 3, 2025

Conversation

benjackwhite
Copy link
Contributor

@benjackwhite benjackwhite commented Jan 30, 2025

Problem

We don't want to offer these in the UI but we do want to be able to work with them when we migrate plugins over. This is all used plugins on the US.

Changes

  • Adds them in as non-modified a way as possible
  • Also includes geoip as I figured it may be easier to do the migration this way for everything and then follow up after

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@benjackwhite benjackwhite marked this pull request as ready for review January 31, 2025 10:47
@benjackwhite benjackwhite changed the base branch from master to feat/hog-transformation-comparer January 31, 2025 10:48
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR adds several deprecated transformation plugins to the PostHog plugin server to support plugin migration. Here's a concise summary of the key changes:

  • Added LegacyPluginExecutorService to handle deprecated transformations with GeoIP functionality through hub.mmdb service
  • Implemented various transformation plugins including GeoIP, URL normalization, event deduplication, and property filtering
  • Added comprehensive test coverage for each plugin including edge cases and error scenarios
  • Removed metadata imports from plugins and consolidated plugin type definitions
  • Added test helpers for GeoLite2 City database testing

Key points to review:

  • Several plugins have potential issues with error handling and input validation that should be addressed
  • Some plugins are marked as 'alpha' status despite being deprecated, which could be confusing
  • The GeoIP functionality appears in both deprecated and active plugins, potential for conflicts
  • Direct mutation of event objects in some plugins could cause side effects
  • Some plugins lack proper documentation about transformation purposes and edge cases

66 file(s) reviewed, 81 comment(s)
Edit PR Review Bot Settings | Greptile

Base automatically changed from feat/hog-transformation-comparer to master January 31, 2025 14:38
@benjackwhite benjackwhite requested a review from a team January 31, 2025 14:39
@benjackwhite benjackwhite merged commit 201641c into master Feb 3, 2025
92 checks passed
@benjackwhite benjackwhite deleted the feat/all-the-transformations branch February 3, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants