-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add all deprecated transformations #28097
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto feat/cyclotron-plugins
benjackwhite
changed the base branch from
master
to
feat/hog-transformation-comparer
January 31, 2025 10:48
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR adds several deprecated transformation plugins to the PostHog plugin server to support plugin migration. Here's a concise summary of the key changes:
- Added LegacyPluginExecutorService to handle deprecated transformations with GeoIP functionality through hub.mmdb service
- Implemented various transformation plugins including GeoIP, URL normalization, event deduplication, and property filtering
- Added comprehensive test coverage for each plugin including edge cases and error scenarios
- Removed metadata imports from plugins and consolidated plugin type definitions
- Added test helpers for GeoLite2 City database testing
Key points to review:
- Several plugins have potential issues with error handling and input validation that should be addressed
- Some plugins are marked as 'alpha' status despite being deprecated, which could be confusing
- The GeoIP functionality appears in both deprecated and active plugins, potential for conflicts
- Direct mutation of event objects in some plugins could cause side effects
- Some plugins lack proper documentation about transformation purposes and edge cases
66 file(s) reviewed, 81 comment(s)
Edit PR Review Bot Settings | Greptile
...in-server/src/cdp/legacy-plugins/_transformations/Plugin-Stonly-Clean-Campaign-Name/index.ts
Show resolved
Hide resolved
...in-server/src/cdp/legacy-plugins/_transformations/Plugin-Stonly-Clean-Campaign-Name/index.ts
Show resolved
Hide resolved
plugin-server/src/cdp/legacy-plugins/_transformations/drop-events-on-property-plugin/index.ts
Show resolved
Hide resolved
plugin-server/src/cdp/legacy-plugins/_transformations/drop-events-on-property-plugin/index.ts
Show resolved
Hide resolved
plugin-server/src/cdp/legacy-plugins/_transformations/posthog-route-censor-plugin/template.ts
Show resolved
Hide resolved
plugin-server/src/cdp/legacy-plugins/_transformations/property-filter-plugin/index.ts
Outdated
Show resolved
Hide resolved
plugin-server/src/cdp/legacy-plugins/_transformations/timestamp-parser-plugin/index.ts
Outdated
Show resolved
Hide resolved
MarconLP
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We don't want to offer these in the UI but we do want to be able to work with them when we migrate plugins over. This is all used plugins on the US.
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?