Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(data-warehouse): Format the rows synced figure on the syncs tab #28103

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

Gilbert09
Copy link
Member

Changes

  • Format the "rows synced" column on the syncs tab when viewing a warehouse source

Before:
image

@Gilbert09 Gilbert09 requested a review from a team January 30, 2025 16:20
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Added number formatting to improve readability of the 'Rows synced' column in the data warehouse source syncs view.

  • Modified frontend/src/scenes/data-warehouse/settings/source/Syncs.tsx to format row counts using toLocaleString() for better readability of large numbers

1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

@@ -44,7 +44,7 @@ export const Syncs = ({ id }: SyncsProps): JSX.Element => {
{
title: 'Rows synced',
render: (_, job) => {
return job.rows_synced
return job.rows_synced.toLocaleString()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Add null/undefined check before calling toLocaleString() to prevent runtime errors

Copy link
Contributor

Size Change: 0 B

Total Size: 1.16 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.16 MB

compressed-size-action

@Gilbert09 Gilbert09 enabled auto-merge (squash) January 30, 2025 17:08
@Gilbert09 Gilbert09 merged commit a1fcbf4 into master Jan 30, 2025
100 checks passed
@Gilbert09 Gilbert09 deleted the tom/local-rows-synced branch January 30, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants