fix: separate PropertyValue component for feature flags #28125
Conversation
lucasheriques
added
feature/feature-flags
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Extracted property value rendering logic into a dedicated PropertyValueComponent in FeatureFlagReleaseConditions.tsx to improve code organization and fix duplicate operator text display.
- Created new
PropertyValueComponentto handle rendering of cohort links, date filters, and property values - Fixed duplicate "is set"/"is not set" operator text by handling these cases explicitly in the component
- Added proper date formatting for relative date filters with customizable format strings
- Improved cohort value display by showing cohort name with external link when available
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
| if (property.value === PropertyOperator.IsNotSet || property.value === PropertyOperator.IsSet) { | ||
| return <></> | ||
| } |
There was a problem hiding this comment.
only logic changes on the PR, otherwise I just moved the lines into a new function for easier readability
|
Size Change: +5 B (0%) Total Size: 1.16 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
|
@lucasheriques the PR title should be about the bug fix though, its a |
lucasheriques
changed the title
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Problem
Prevents the duplicate
is set/is not setfrom showing up in feature flag conditionsTagging the feature flags team as well as it affect both surveys and FFs
Changes
Does this work well for both Cloud and self-hosted?
N/A
How did you test this code?
Tested locally if component matches what is expected