fix: inspector search position #28176
Merged
+10
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauldambra
commented
Feb 1, 2025
| @@ -262,14 +268,15 @@ export function PlayerInspectorControls(): JSX.Element { | |||
| }, [featureFlags, setMiniFilter]) | |||
|
|
|||
| return ( | |||
| <div className="flex"> | |||
| <div className="flex flex-col"> | |||
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Fixed search positioning and enhanced testing capabilities in the session recordings player inspector component.
- Changed root div layout from
flextoflex flex-colin/frontend/src/scenes/session-recordings/player/inspector/PlayerInspectorControls.tsxto correctly position search bar below settings - Added systematic
data-attrattributes (e.g. 'player-inspector-*') to interactive elements for improved testing coverage
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
Size Change: 0 B Total Size: 1.16 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inspector is opening search in the wrong position
let's fix that
while we're here, add data attrs to the buttons and toggles