fix: set posthoganalytics key in asgi #28627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR fixes an issue with PostHog analytics initialization in ASGI debug mode by implementing async-compatible analytics key setting functionality.
- Added
wrap_debug_analyticsdecorator in/posthog/asgi.pyto handle async initialization of analytics key - Implemented flag-based initialization check to prevent redundant key setting on subsequent requests
- Applied wrapper only in debug mode to maintain production behavior
- Added async function
aset_debugging_analytics_key()in/posthog/utils.pyfor ASGI-compatible analytics key setting
2 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
posthog/asgi.py
Outdated
Comment on lines
27
to
28
| if not getattr(inner, "debug_analytics_initialized", False): | ||
| from posthog.utils import aset_debugging_analytics_key |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
posthog/utils.py
Outdated
| else: | ||
| team = await Team.objects.only("api_token").afirst() | ||
| local_api_key = team.api_token | ||
| except: |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
timgl
approved these changes
Feb 12, 2025
|
Yup, looks like this is the way. I refactored things so that all self-capture, across backend and frontend, relies on this async |
Twixes
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Django has been running on ASGI in debug mode for two days. Suddenly, local LLM traces stopped working somewhere around that time. The root problem is in the
posthog.apps.PostHogConfig.ready()method, which now runs in an async context, so the ORM must also be called in async mode. However, theready()method doesn't have an async alternative—Detailed explanation.Changes
Add a debug-only wrapper for the ASGI web server, which initializes the
posthoganalyticspackage. @Twixes, you might have a better idea of how we can fix it.Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Manual and local testing.