Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: HogQL expression to SQL #28640

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ivanagas
Copy link
Contributor

@ivanagas ivanagas commented Feb 12, 2025

Problem

HogQL expression label still shows on filters, but it should be SQL for consistency

CleanShot 2025-02-12 at 13 20 56@2x

To match: #28471

Changes

Change HogQL label to SQL in filters

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

Automated tests take the wheel

(Please merge for me because it will take me like one whole day to get local dev working)

@ivanagas ivanagas requested a review from timgl February 12, 2025 21:25
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR makes a straightforward labeling change in the taxonomic filter component, replacing "HogQL expression" with "SQL expression" for better UI consistency.

  • Changed label in frontend/src/lib/components/TaxonomicFilter/taxonomicFilterLogic.tsx from "HogQL expression" to "SQL expression" while maintaining the underlying TaxonomicFilterGroupType.HogQLExpression type
  • Updated both the name and popover header text for the expression filter group
  • No functional changes to the filtering behavior or underlying HogQL implementation

💡 (2/5) Greptile learns from your feedback when you react with 👍/👎!

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

Size Change: +5 B (0%)

Total Size: 1.18 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.18 MB +5 B (0%)

compressed-size-action

@ivanagas ivanagas changed the title HogQL expression to SQL fix: HogQL expression to SQL Feb 12, 2025
@ivanagas ivanagas requested review from a team and removed request for timgl February 12, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant