chore: embeddable hog function configuration #28671
Conversation
| {showStatus && <HogFunctionStatusIndicator hogFunction={hogFunction} />} | ||
| {showEnabled && ( | ||
| <LemonField name="enabled"> | ||
| {showLeftPanel && ( |
There was a problem hiding this comment.
Looks like there is a lot going on here but it is just indentation from this check & some minor changes from new displayOptions
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds support for configuring error tracking alerts with a simplified UI by introducing hidden input fields and embedded display options. Here are the key changes:
- Added new
hiddenproperty to input schema fields to keep default values while hiding them from the UI - Introduced
embeddeddisplay mode with conditional border rendering and panel visibility controls - Added new
error-tracking-issue-createdSlack sub-template with hidden blocks/text fields - Modified HogFunctionInputs to filter out hidden inputs using
?.filter((i) => !i.hidden) - Added flexible display options like
hidePageHeaderandhideOverviewfor embedded use cases
The changes enable a more focused configuration experience for error tracking alerts while maintaining the full functionality behind the scenes.
5 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
| Update | ||
| <div className="flex items-center flex-1 gap-2 pt-2 border-t"> | ||
| <div className="flex-1"> | ||
| <LemonButton>Close</LemonButton> |
There was a problem hiding this comment.
logic: Close button has no onClick handler, making it non-functional
| "default": [ | ||
| { | ||
| "text": { | ||
| "text": "*{person.properties.email}* {event.properties.activity} {event.properties.scope} {event.properties.item_id} ", |
There was a problem hiding this comment.
logic: The message format reuses activity log properties but error tracking events may have different property names. Verify that event.properties.activity, scope, and item_id exist for $error_tracking_issue_created events.
daibhin
changed the title
|
Size Change: 0 B Total Size: 1.2 MB ℹ️ View Unchanged
|
| @@ -4666,6 +4666,7 @@ export type HogFunctionInputSchemaType = { | |||
| required?: boolean | |||
| default?: any | |||
| secret?: boolean | |||
| hidden?: boolean | |||
There was a problem hiding this comment.
One thing - we have this in the plugin-server as well. It's not a biggy but would be cool to add it to the types there as well so we dont forget about it
There was a problem hiding this comment.
Will do. I left it out specifically because it was more of a frontend concern but happy to add it
Problem
Towards #28670. Pulled out all the changes needed to CDP components
Changes
Idea is to be able to let someone configure alerts within the error tracking settings but not have full access to the configuration UI (just certain fields)
embeddeddisplay option