Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(err): use issue_id for issue events query #28673

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Conversation

oliverb123
Copy link
Contributor

No description provided.

@posthog-bot
Copy link
Contributor

Hey @oliverb123! 👋
This pull request seems to contain no description. Please add useful context, rationale, and/or any other information that will help make sense of this change now and in the distant Mars-based future.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR modifies the error tracking issue events query to use a different field for filtering events related to merged issues.

  • Changed field reference in frontend/src/scenes/error-tracking/queries.ts from properties.$exception_issue_id to issued_id, but appears to contain a typo (should likely be issue_id)
  • Query change aims to properly handle events from merged error tracking issues that were previously not being included

1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

frontend/src/scenes/error-tracking/queries.ts Outdated Show resolved Hide resolved
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Copy link
Contributor

Size Change: 0 B

Total Size: 1.18 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.18 MB

compressed-size-action

@oliverb123 oliverb123 enabled auto-merge (squash) February 13, 2025 16:00
@oliverb123 oliverb123 merged commit 9eaabed into master Feb 13, 2025
102 of 103 checks passed
@oliverb123 oliverb123 deleted the oliverb123-patch-1 branch February 13, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants