-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Haskell memory tests #1286
Haskell memory tests #1286
Conversation
Tests are currently failing, due to different measurements, which I guess stem from hardware differences. This could be easily changed to accommodate Circle. On both circle and locally the results seems to be consistent, though. I've also tried Keeping it that way for until further discussion. Edit: To run new test-suit only: |
@Qu4tro Cool usage of weigh. Is the intention to replace the bash test suite? Also, I've ran the new test suite several times and somehow it takes like 5-6 minutes to complete. Does the same happen to you? |
Yes, the intention would be to get rid of the bash tests. I think having them in Haskell, would incentivize the creation of more memory tests. Do you mean both test-suits or just the memory one? |
Only running |
Ah thanks. Will fix. I should also be able to get the status codes of the responses, so that these mistakes are easily found . |
@steve-chavez if it helps, the output of inxi on my laptop:
|
222f7a8
to
a3c1ecc
Compare
We're now getting a lot of out of memory errors when compiling with @Qu4tro I wanted to ask you, using weigh requires compiling with profiling enabled? From this PR I'm left with the impression that it's not required. I'm wondering how |
Hmm. This kind of explains that weigh doesn't need ghc profiling enabled fpco/weigh#14. |
Still like the idea of having the memory tests in Haskell. The code here is really good so I'll leave the PR open for someone to pick it up. |
An all-haskell test suite doesn't look close at the moment: we even have IO tests in python now. We might get more attempts at this after #1804 is done. |
Hey there,
This PR creates a new test-suit. This test suit is meant to measure memory-usage in the likes of the current
memory-tests.sh
. It uses the weigh package to provide the necessary tooling.One thing of note is that the results don't match to bash tests. I'm not sure why that it is, yet.
Additionally and TODO: Check status code of requests.