Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: include base v4.17 to support ghc 9.4 #3111

Closed
wants to merge 1 commit into from

Conversation

laurenceisla
Copy link
Member

Closes #3107

@laurenceisla
Copy link
Member Author

It looks like other libraries need to be updated too:

  • base needs 4.17
  • text needs at least 2.0.1 due to needing ghc-prim 0.9 (possibly breaking update).
  • fuzzyset needs 0.2.4 due to needing text

I'm closing for now since it would take me some more time to test this. Anyone who wishes to continue feel free to take it.

@steve-chavez
Copy link
Member

@laurenceisla I see CI passed this one. What was the issue?

@laurenceisla
Copy link
Member Author

laurenceisla commented Dec 14, 2023

@steve-chavez CI is using GHC 9.2, but it fails on GHC 9.4 (at least for me) so it wouldn't comply with that version... updating only base won't do much, I think.

@laurenceisla laurenceisla mentioned this pull request Dec 14, 2023
@laurenceisla
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Support ghc 9.4
2 participants