fix: bind admin server to the same host #3512
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tries to reuse main socket address to bind admin socket there too
develop7
force-pushed
the
fix-3508-same-proto
branch
from
6e5906f
to
b6267aa
Compare
|
Since this will use the same host, then it would log this when the same port is used, right? It solves the issue of not allowing the same ports, but I think it's better/simpler to just not execute when |
|
Closing this in favor of #3559 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reuse main socket address to bind admin socket there too by resolving the address main socket is bound at and binding admin socket to it explicitly.
Introduces extra dependency to
iprouteforHostAddress -> IP -> Stringconversions, following the reference in https://www.stackage.org/haddock/lts-22.21/network-3.1.4.0/src/Network.Socket.Info.html#line-415Fixes #3508