perf: Pass arguments to RPCs called via GET directly

[wolfgangwalther]

Previously they were passed as a JSON payload. This results in a LATERAL join for the calling expression, which prevents LIMIT from being pushed into the inlined function call, making some requests really slow.

Resolves #2858

I'm actually quite surprised that all tests were still passing when I made the build pass. I have not tried to confirm that this makes the respective RPC calls faster, but I'm pretty certain it should do so. I observed the same thing as @steve-chavez did in #2858 (comment) in one of my projects.

[wolfgangwalther]

Taking the examples from #2858:

The old query looked like this:

SELECT "pgrst_call".*
FROM ( SELECT '{"unseen_only":"true","uid":"AJwLWoo3xue32XIiAVrL5SyR1WB2","max_num":"300"}'::jsonb AS json_data) pgrst_payload,
LATERAL (SELECT CASE WHEN jsonb_typeof(pgrst_payload.json_data) = 'array' THEN pgrst_payload.json_data ELSE jsonb_build_array(pgrst_payload.json_data) END AS val) pgrst_uniform_json,
LATERAL (SELECT "uid", "unseen_only", "max_num" FROM jsonb_to_recordset(pgrst_uniform_json.val) AS _("uid" text, "unseen_only" boolean, "max_num" integer) LIMIT 1) pgrst_body,
LATERAL "test"."get_notifications"("uid" := pgrst_body."uid", "unseen_only" := pgrst_body."unseen_only", "max_num" := pgrst_body."max_num") pgrst_call;

The new query looks like this:

SELECT "pgrst_call".*
FROM "test"."get_notifications"("uid" := 'AJwLWoo3xue32XIiAVrL5SyR1WB2', "unseen_only" := true, "max_num" := 300) pgrst_call;

[steve-chavez]

The new query looks like this

Looks good! I think the plan cost should improve with that new query. If so, perhaps we can test it on PlanSpec.hs?

[wolfgangwalther]

I think the plan cost should improve with that new query. If so, perhaps we can test it on PlanSpec.hs?

I guess it should, yes. I will have a look.

[wolfgangwalther]

I think the plan cost should improve with that new query. If so, perhaps we can test it on PlanSpec.hs?

I guess it should, yes. I will have a look.

I lowered the existing cost expectations for function calls with arguments as they were done with GET.