-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove support for Prefer: params=single-object #3757
remove support for Prefer: params=single-object #3757
Conversation
Using this preference was deprecated in 6c3d7a9, in favor of Functions with an array of JSON objects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eyeballing it, it LGTM. CI is also green. Should be good to go.
@@ -5,6 +5,10 @@ This project adheres to [Semantic Versioning](http://semver.org/). | |||
|
|||
## Unreleased | |||
|
|||
### Removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is similar to the removal of PG 9.6 / 10 / 11 support and could go to "Changed".
The commits for that were done with feat:
prefix, so I guess this one should be as well. Yeah.. it's quite the opposite of a "new feature", but it's not any of the prefixes we use either ;)
Co-authored-by: Wolfgang Walther <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 👍
I don't think the CHANGELOG was addressed properly. Now we have a Removed section at the top. We didn't have any removed sections before and if so we should have it at the bottom. In any case, the PG removal should be in the same section. As I wrote above, this should just be in the "Changed" section. Also, @steve-chavez, I think we loosely agreed on some form of conventional commits, i.e. using prefixes. The squashed commit message has none. |
Ah, my bad, I thought it was addressed. How about this?
All in one push to main? |
Btw, maybe we can enforce this somehow? https://dev.to/mbarzeev/a-git-hook-for-commit-messages-validation-no-husky-just-js-1hni I guess squash would have to be disabled too. |
I don't think you need to revert. I'd say it's fine to just do the changelog in a follow up commit. We'd have to think about the proper commit prefix for something like this. I used
Yeah, I use |
No, I think squash is fine. You can still edit the commit message when squashing. |
Fixed the changelog on b821857 |
Using this preference was deprecated in 6c3d7a9, in favor of Functions with an array of JSON objects.
This change removes support for this feature, planned for the next major version.