Table name with primary key for selected items export

[eafarooqi]

⚡ PowerGrid - Pull Request

• Bug fix
• Enhancement
• New feature
• Breaking change

Description

With a complex query as datasource with joins, when exporting selected items you get an ambiguous primary key error. Table name is missing in the where query.

Related Issue(s): #1841

Documentation

This PR requires Documentation update?

• Yes
• No
• I have already submitted a Documentation pull request.

[luanfreitasdev]

What do you think of this solution? We could create a method inside the component and use it in ExportableJob as well.

$property = fn (string $property) => Support\Str::of($processDataSource->component->{$property})->contains('.')
            ? $processDataSource->component->{$property}
            : $currentTable . '.' . $processDataSource->component->{$property};

        $results = $processDataSource->component->datasource()
            ->where(
                fn ($query) => Builder::make($query, $this)
                    ->filterContains()
                    ->filter()
            )
            ->when($filtered, function ($query, $filtered) use ($property) {
                return $query->whereIn($property('primaryKey'), $filtered);
            })
            ->orderBy($property('sortField'), $processDataSource->component->sortDirection)
            ->get();

[eafarooqi]

What do you think of this solution? We could create a method inside the component and use it in ExportableJob as well.

$property = fn (string $property) => Support\Str::of($processDataSource->component->{$property})->contains('.')
            ? $processDataSource->component->{$property}
            : $currentTable . '.' . $processDataSource->component->{$property};

        $results = $processDataSource->component->datasource()
            ->where(
                fn ($query) => Builder::make($query, $this)
                    ->filterContains()
                    ->filter()
            )
            ->when($filtered, function ($query, $filtered) use ($property) {
                return $query->whereIn($property('primaryKey'), $filtered);
            })
            ->orderBy($property('sortField'), $processDataSource->component->sortDirection)
            ->get();

Totally agree! that's better