Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boring pdnsutil cleanups #15051

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

miodvallat
Copy link
Contributor

@miodvallat miodvallat commented Jan 17, 2025

Short description

This boring PR boringly addresses coverity complaints about pdnsutil, as well as some easy-to-do clang-tidy ones.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • warned people that this is a boring PR multiple times

@coveralls
Copy link

coveralls commented Jan 17, 2025

Pull Request Test Coverage Report for Build 12833904435

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 16 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.04%) to 64.732%

Files with Coverage Reduction New Missed Lines %
pdns/recursordist/sortlist.cc 2 72.94%
modules/lmdbbackend/lmdbbackend.cc 2 73.7%
pdns/packethandler.cc 3 72.35%
pdns/iputils.cc 3 56.84%
pdns/recursordist/test-syncres_cc1.cc 6 89.8%
Totals Coverage Status
Change from base Build 12832418127: 0.04%
Covered Lines: 127851
Relevant Lines: 166436

💛 - Coveralls

@miodvallat miodvallat force-pushed the pdnsutil_eulenspiegel branch from 3339cd6 to 334259f Compare January 17, 2025 15:50
@miodvallat miodvallat force-pushed the pdnsutil_eulenspiegel branch from 334259f to de39174 Compare January 17, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants