Fix compiler warnings (#335)

* Update configure.ac with new libtool macro * Fix compiler warnings * also fix maybe-uninitialized warning Co-authored-by: Charles-Henri Bruyand <[email protected]>
PowerDNS · May 12, 2021 · fa0ab51 · fa0ab51
1 parent 5da14e9
commit fa0ab51
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 11 deletions.
diff --git a/common/perf-stats.cc b/common/perf-stats.cc
@@ -227,7 +227,7 @@ Json perfStatsToJson()
 Json commandStatsToJson()
 {
   Json::object jattrs;
-  for (const auto i : command_stats) {
+  for (const auto& i : command_stats) {
     jattrs.insert(std::make_pair(i, getCommandStat(i)));
   }
   return jattrs;
@@ -236,7 +236,7 @@ Json commandStatsToJson()
 Json customStatsToJson()
 {
   Json::object jattrs;
-  for (const auto i : custom_stats) {
+  for (const auto& i : custom_stats) {
     jattrs.insert(std::make_pair(i, getCustomStat(i)));
   }
   return jattrs;

diff --git a/common/webhook.hh b/common/webhook.hh
@@ -204,7 +204,7 @@ public:
   const WHConfigMap& addConfigKeys(const WHConfigMap& new_cfg)
   {
     std::lock_guard<std::mutex> lock(mutex);
-    for (const auto i : new_cfg) {
+    for (const auto& i : new_cfg) {
       config_keys.insert(std::make_pair(i.first, i.second));
     }
     return config_keys;

diff --git a/configure.ac b/configure.ac
@@ -1,4 +1,4 @@
-AC_INIT([wforce], [2.4.1-alpha1])
+AC_INIT([wforce],[2.4.1-alpha1])
 AM_INIT_AUTOMAKE([foreign dist-bzip2 parallel-tests 1.11 subdir-objects])
 AM_SILENT_RULES([yes])
 AC_CONFIG_MACRO_DIR([m4])
@@ -47,7 +47,7 @@ AS_IF([test "x$YAMLCPP_LIBS" = "x"], [
   AC_MSG_ERROR([yaml-cpp not found, yaml-cpp support is required])
 ])
 AM_CONDITIONAL([LIBSYSTEMD],[test "$HAVE_LIBSYSTEMD" = "1"])
-AC_PROG_LIBTOOL
+LT_INIT
 # We need readline
 WFORCE_CHECK_READLINE
 # Boost-specific checks

diff --git a/wforce/wforce-lua.cc b/wforce/wforce-lua.cc
@@ -494,7 +494,7 @@ vector<std::function<void(void)>> setupLua(bool client, bool multi_lua, LuaConte
     c_lua.writeFunction("showAddrByName", [](std::shared_ptr<WFResolver> resolvp, string name) {
       std::vector<std::string> retvec = resolvp->lookup_address_by_name(name, 1);
       boost::format fmt("%s %s\n");
-      for (const auto s : retvec) {
+      for (const auto& s : retvec) {
         g_outputBuffer += (fmt % name % s).str();
       }
     });
@@ -506,7 +506,7 @@ vector<std::function<void(void)>> setupLua(bool client, bool multi_lua, LuaConte
     c_lua.writeFunction("showNameByAddr", [](std::shared_ptr<WFResolver> resolvp, ComboAddress address) {
       std::vector<std::string> retvec = resolvp->lookup_name_by_address(address, 1);
       boost::format fmt("%s %s\n");
-      for (const auto s : retvec) {
+      for (const auto& s : retvec) {
         g_outputBuffer += (fmt % address.toString() % s).str();
       }
     });
@@ -519,7 +519,7 @@ vector<std::function<void(void)>> setupLua(bool client, bool multi_lua, LuaConte
     c_lua.writeFunction("showRBL", [](std::shared_ptr<WFResolver> resolvp, ComboAddress address, string rblname) {
       std::vector<std::string> retvec = resolvp->lookupRBL(address, rblname, 1);
       boost::format fmt("%s\n");
-      for (const auto s : retvec) {
+      for (const auto& s : retvec) {
         g_outputBuffer += (fmt % s).str();
       }
     });

diff --git a/wforce/wforce.cc b/wforce/wforce.cc
@@ -173,7 +173,7 @@ try
   sock.setKeepAlive();
 
   for(;;) {
-    uint16_t len;
+    uint16_t len{0};
     if(!getMsgLen(fd, &len))
       break;
     char msg[len];
@@ -294,7 +294,7 @@ void doClient(ComboAddress server, const std::string& command)
     string msg=sodEncryptSym(command, g_key, writingNonce);
     putMsgLen(fd, msg.length());
     writen2(fd, msg);
-    uint16_t len;
+    uint16_t len{0};
     getMsgLen(fd, &len);
     char resp[len];
     readn2(fd, resp, len);
@@ -336,7 +336,7 @@ void doClient(ComboAddress server, const std::string& command)
     string msg=sodEncryptSym(line, g_key, writingNonce);
     putMsgLen(fd, msg.length());
     writen2(fd, msg);
-    uint16_t len;
+    uint16_t len{0};
     getMsgLen(fd, &len);
     char resp[len];
     readn2(fd, resp, len);