Update pricing for Fall 2024 #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nwalters512
commented
Dec 11, 2024
src/pages/pricing/index.tsx
Outdated
| <Row> | ||
| <Col xs={12} md={6}> | ||
| <Form.Group controlId="term-system"> | ||
| <Form.Label>Term system</Form.Label> |
There was a problem hiding this comment.
Is this the right term (heh) to use here?
There was a problem hiding this comment.
"Term system" is a correct terminology. We could also consider "academic schedule"
There was a problem hiding this comment.
I prefer "academic schedule", but I agree that "term system" is correct as well.
There was a problem hiding this comment.
Changed to "academic calendar" in 7129fb5.
There was a problem hiding this comment.
err, no I didn't 😅 let me change it again.
There was a problem hiding this comment.
Done for real in 56ec012.
src/pages/pricing/index.tsx
Outdated
Comment on lines
145
to
160
| let basicPrice = run(() => { | ||
| if (termSystem === "semester") { | ||
| return 8; | ||
| } else if (termSystem === "quarter") { | ||
| return 6; | ||
| } else { | ||
| return 2; | ||
| } | ||
| }); | ||
|
|
||
| let premiumPrice = basicPrice * 2; | ||
|
|
||
| if (paymentModel === "student") { | ||
| basicPrice += 2; | ||
| premiumPrice += 2; | ||
| } |
There was a problem hiding this comment.
Check my math please!
mwest1066
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.