Skip to content

Commit

Permalink
Add ignore comments for wonky otel typing
Browse files Browse the repository at this point in the history
  • Loading branch information
desertaxle committed Feb 27, 2025
1 parent 15e400d commit afb07e7
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/prefect/telemetry/instrumentation.py
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ def _setup_meter_provider(
resource: Resource, headers: dict[str, str], telemetry_url: str
) -> MeterProvider:
metric_reader = PeriodicExportingMetricReader(
OTLPMetricExporter(
OTLPMetricExporter( # pyright: ignore[reportArgumentType] `preferred_temporality` and `preferred_aggregation` default to `None`, but otel's typing doesn't include it
endpoint=_url_join(telemetry_url, "v1/metrics"),
headers=headers,
)
Expand All @@ -109,7 +109,7 @@ def _setup_meter_provider(
def _setup_logger_provider(
resource: Resource, headers: dict[str, str], telemetry_url: str
) -> LoggerProvider:
logger_provider = LoggerProvider(resource=resource)
logger_provider = LoggerProvider(resource=resource) # pyright: ignore[reportArgumentType] `multi_log_record_processor` defaults to `None` but otel's typing doesn't include it
queueing_log_exporter = QueueingLogExporter.instance(
_url_join(telemetry_url, "v1/logs"), tuple(headers.items())
)
Expand Down

0 comments on commit afb07e7

Please sign in to comment.