Do not overwrite configuration #1155
Conversation
Hlavtox
force-pushed
the
do-not-overwrite-configuration
branch
from
a656a86 to
654453d
Compare
|
@Hlavtox I think with new CI merged yesterday you are on error with header. Can you rebase please. |
|
@ga-devfront Brother, what do mean by header? It can be merged, there are no conflicts. :-) (I can rebase when I get to my PC of course, no worries.) |
We have modified the package that manages header stamps and added it to this project. Even if there is no conflict currently it is very likely that once merged the CI that checks header stamps will end up in error because the header stamps of your PR does not exactly match the new one expected. |
Hlavtox
force-pushed
the
do-not-overwrite-configuration
branch
from
654453d to
78f23c2
Compare
|
@ga-devfront @M0rgan01 @Quetzacoalt91 Guys, just rebased it, should be good now. :-)
Thank you Guyomar! :-) No worries, making it better makes the process easier for everyone. |
| ('PS_IMAGE_FORMAT', 'jpg', NOW(), NOW()) | ||
| ; | ||
| /* PHP:add_configuration_if_not_exists('PS_PRODUCT_REDIRECTION_DEFAULT', '404'); */; | ||
| /* PHP:add_configuration_if_not_exists('PS_MAINTENANCE_ALLOW_ADMINS', '1'); */; |
There was a problem hiding this comment.
Not sure if this is important, but I see the original value was an integer.
There was a problem hiding this comment.
It will behave the same when inserting it into the database, but I can change it if you want me to.
There was a problem hiding this comment.
If you're certain the result will be the same, no need to change it.
Hlavtox
dismissed stale reviews from Quetzacoalt91, ga-devfront, and M0rgan01
via
ccfe883
|
|
Guys, had to change the header, one more approve pls. BTW, there is something wrong in the header stamping tool of yours. :-))) See: |
I did not check, but it would either fail or insert a duplicate entry.