-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enchancement: update extract translation to only push on one branch #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ga-devfront
commented
Jul 12, 2024
Questions | Answers |
---|---|
Description? | Currently we got multiple PR then we have new translation (possibly with same content), we fix this by pushing only changes in one branche named 'translation-extraction' |
Type? | improvement |
BC breaks? | no |
Deprecations? | no |
Sponsor company | @PrestaShopCorp |
How to test? | Add translations and merge multiple PR on dev and check if we got one or many PR. |
Quetzacoalt91
approved these changes
Jul 16, 2024
Quetzacoalt91
changed the title
enchancement: update extract translation to only push on one branche
enchancement: update extract translation to only push on one branch
Jul 16, 2024
PR merged, well done! Message to @PrestaShop/committers: do not forget to milestone it before the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.