Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the percentage of progression on upgrade and restore workflows #799

Merged
merged 20 commits into from
Jul 29, 2024
Merged

Implement the percentage of progression on upgrade and restore workflows #799

merged 20 commits into from
Jul 29, 2024

Conversation

Quetzacoalt91
Copy link
Member

@Quetzacoalt91 Quetzacoalt91 commented Jul 12, 2024 •
edited
Loading

Questions Answers
Description? On the next UI, we expect a progress bar to be displayed for a better experience during the update process. This PR prepares the back end to send this information back to the UI.
Note: this PR does not change the interface.
Type? new feature
BC breaks? Nope
Deprecations? Nope
Fixed ticket? /
Sponsor company @PrestaShopCorp
How to test? Ajax requests return a progress percentage during the restoration and upgrade process.

Example of UI with a progress bar relying on this new information

Capture.video.du.2024-07-11.17-47-51.webm

@Quetzacoalt91 Quetzacoalt91 self-assigned this Jul 12, 2024
@Quetzacoalt91 Quetzacoalt91 changed the title Progress bar Implement the percentage of progression on upgrade and restore Jul 12, 2024
@Quetzacoalt91 Quetzacoalt91 changed the title Implement the percentage of progression on upgrade and restore Implement the percentage of progression on upgrade and restore workflows Jul 12, 2024
@Quetzacoalt91 Quetzacoalt91 marked this pull request as ready for review July 15, 2024 16:05
@Quetzacoalt91 Quetzacoalt91 added this to the 7.0.0 milestone Jul 15, 2024
M0rgan01
M0rgan01 reviewed Jul 18, 2024
View reviewed changes
classes/State.php Outdated Show resolved Hide resolved
classes/Task/AbstractTask.php Outdated Show resolved Hide resolved
classes/Task/Rollback/RestoreFiles.php Outdated Show resolved Hide resolved
@Quetzacoalt91 Quetzacoalt91 marked this pull request as draft July 18, 2024 17:47
@Quetzacoalt91 Quetzacoalt91 force-pushed the progress-bar branch 2 times, most recently from 5205d26 to c96da96 Compare July 18, 2024 17:53
@Quetzacoalt91
Copy link
Member Author

Now the percentage stuff has been extracted, there are some unit tests that can be added before sending this PR back to review

@Quetzacoalt91 Quetzacoalt91 marked this pull request as ready for review July 19, 2024 10:22
M0rgan01
M0rgan01 previously approved these changes Jul 19, 2024
View reviewed changes
@Quetzacoalt91 Quetzacoalt91 modified the milestones: 7.0.0, 6.1.0 Jul 23, 2024
@AureRita AureRita self-assigned this Jul 29, 2024
AureRita
AureRita approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@AureRita AureRita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Quetzacoalt91

Thank you for your PR, I tested it and it seems to works as you can see :

recording.263.webm

Tested from :
1.7.8.9 to 8.1.7
8.0.5 to 8.1.7
8.1.5 to 8.1.7
8.1.7 to 9.0.0
8.1.5 to 9.0.0
8.0.5 to 9.0.0

Because the PR seems to works as expected, It's QA ✔️

Thank you

@Quetzacoalt91 Quetzacoalt91 merged commit 7e99c29 into PrestaShop:dev Jul 29, 2024
34 checks passed
@Quetzacoalt91 Quetzacoalt91 deleted the progress-bar branch December 20, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AureRita AureRita AureRita approved these changes

@M0rgan01 M0rgan01 M0rgan01 left review comments

Assignees

@Quetzacoalt91 Quetzacoalt91

@AureRita AureRita

Labels
new feature QA ✔️
Projects
PR Dashboard
Archived in project
Milestone
6.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Quetzacoalt91 @M0rgan01 @AureRita @ps-jarvis