-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add products reviews to schema.org #319
base: develop
Are you sure you want to change the base?
Conversation
Anything i can do?. I dont know if i close the requested changes or what. I new to this github part |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it's acceptable for now, but I would like the @Hlavtox advice as he commented something
@NeOMakinG @rodriciru @matks Everything is good with the JSON work, I approve, but let's use the moment to think about unifying the structure. What if we just require all review modules to provide data in standardized format? So if you swap a review module, all will work. |
I love standardization. |
I agree unifying would be good 👍 and |
@Hlavtox so we need to tweak the module itself first? |
Hello, Thanks! |
8bc3796
to
0295657
Compare
Hi @ga-devfront can you tell us why you closed this PR? Is it not relevant anymore Merging this PR was a blocker for PR PrestaShop/productcomments#140 |
My apologies, it was a handling error on my part when I set up the work for PrestaShopCorp... |
This change depends on this pull request, as we have the data from somewhere:
PrestaShop/productcomments#140
But for now i add the code to print the reviews