Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix images on quality council folder #249

Merged
merged 1 commit into from
Jan 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ title: Processes

* [How to manage Issues](./issue-management)

## Pull Request Management

* [Testing Pull Request](./pr-management)

## Software Testing

* [How to test Pull Requests](./test-pr-and-branches)
Expand All @@ -18,4 +22,4 @@ title: Processes

## Release Manager

* [How to contribute to Test and Release plan](./release-manager)
* [How to contribute to Test and Release plan](./release-manager)
Original file line number Diff line number Diff line change
Expand Up @@ -162,13 +162,13 @@ In case any information is missing:

1. Reply using the "Incomplete Issue" template.
2. Set status label to `NMI` (Need More Info) with `Waiting for author` label.
3. **Don’t forget** to add the necessary labels like : **version** (`1.7.8.x`, `8.1.x`, …), **Categoy** (`BO`, `FO`, …), **Pages** (`Products`, `Module`, `Order`, …), …
3. **Don’t forget** to add the necessary labels like : **version** (`1.7.8.x`, `8.1.x`, …), **Category** (`BO`, `FO`, …), **Pages** (`Products`, `Module`, `Order`, …), …

If it is a `Task`, add the necessary labels and place it in Project Kanban:

1. If the task is dev oriented, add the `Developer Feature` label.
2. If the issue seems properly specified, set the status label to `Ready`. Otherwise, set it to `Needs specs`.
3. **Don’t forget** to add these labels like : **Categoy** (`BO`, `FO`, …), **Pages** (`Products`, `Module`, `Order`, …), ….
3. **Don’t forget** to add these labels like : **Category** (`BO`, `FO`, …), **Pages** (`Products`, `Module`, `Order`, …), ….

{{% notice warning %}}
Take some time to verify that the contributor's environment satisfies [PrestaShop's system requirements](https://devdocs.prestashop-project.org/1.7/basics/installation/system-requirements/) for 1.7 or [PrestaShop's system requirements](https://devdocs.prestashop-project.org/8/basics/installation/system-requirements/) for 8.
Expand Down Expand Up @@ -449,4 +449,4 @@ Thanks in advance!
- If you ping someone, ask a direct question! Don't waste their time by making them read the whole thread and guess why did you ping them.
- If the issue is too technical to reproduce, add the “TBR” and “Waiting for Dev” labels. You should also ping @PrestaShop/committers on the issue.

5. If you don’t know if the issue `Major` or `Minor`, please post it in [#quality-assurance](https://app.slack.com/client/TTJ6M3GPL/C05M16TEEGG) and ping QA lead (@Robin Fischer), so they can settle the severity.
5. If you don’t know if the issue `Major` or `Minor`, please post it in [#quality-assurance](https://app.slack.com/client/TTJ6M3GPL/C05M16TEEGG) and ping QA lead (@Robin Fischer), so they can settle the severity.
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ For the color code, we always use **violet** for the **Branch** and this time we
We can find this **number** in the title of the PR, as you can see.


![img.png](images/readme11.png)
<img src="images/readme11.png" alt="img.png" class="mx-lg-4" style="max-width: 700px">


All you have to do now is try to reproduce the issue again to see if the PR corrects it correctly.
Expand All @@ -80,19 +80,19 @@ Now that you've checked that the PR has corrected the issue, you need to make su

To find them, go to the Files changed tab:

![img.png](images/readme12.png)
<img src="images/readme12.png" alt="img.png" class="mx-lg-4" style="max-width: 700px">

You'll then have all the changes made to the PR. To do this, you'll get this view:

![img.png](images/readme13.png)
<img src="images/readme13.png" alt="img.png" class="mx-lg-4" style="max-width: 700px">

Seen like this, it may seem rather difficult to see the differences and what might be impacted, so we advise you to modify the split view and save.

![img.png](images/readme14.png)
<img src="images/readme14.png" alt="img.png" class="mx-lg-4" style="max-width: 700px">

You now have a better view of the various modifications, and can read the whole thing.

![img.png](images/readme15.png)
<img src="images/readme15.png" alt="img.png" class="mx-lg-4" style="max-width: 700px">

No computer skills? But you still need to check that it's not overflowing? There are two things you can do:

Expand All @@ -111,14 +111,14 @@ Once the PR test has been completed, there are two possible situations:

- The PR is valid, it doesn't create any other issue. In this case, we advise you to indicate that it works, to put a video proving it (you may think it's the desired behavior but it's not) and to put the link to the automated tests if you ran them.
In your comment, you'll need to select the Approve option before submitting the review.
![img.png](images/readme16.png)

<img src="images/readme16.png" alt="img.png" class="mx-lg-4" style="max-width: 700px">

- The PR is not valid. In this case, indicate that it doesn't work, put a video showing that it doesn't work and put the link to the automated tests if you ran them (to prove that it brings issues).
If the PR corrects the issue but creates others, it is necessary to specify the steps to reproduce the issue(s) caused by the PR, so that the PR author can correct the errors more easily.
In your comment, you'll need to select the Comment option before submitting the review. The Request changes option will force the same QA to respond to the same PR, whereas it would be preferable for someone else to test it once the changes have been made.
![img.png](images/readme17.png)

<img src="images/readme17.png" alt="img.png" class="mx-lg-4" style="max-width: 700px">

As you can see, in both cases, you'll have to provide a video and a link to the automated tests to show your good faith.

Expand All @@ -130,7 +130,7 @@ If you come across a Module PR, the process remains the same as for a PR (in bro

To do this, start by opening your PR:

![img.png](images/readme18.png)
<img src="images/readme18.png" alt="img.png" class="mx-lg-4" style="max-width: 700px">

We've framed the PR version in **Green** and the "branch "** in **Purple**, represented here by **autoupgrade**.

Expand All @@ -140,7 +140,7 @@ We're going to perform the same operations from the beginning to step 3

So we're going to run a special command in the terminal linked to our shop folder:

![img.png](images/readme19.png)
<img src="images/readme19.png" alt="img.png" class="mx-lg-4" style="max-width: 700px">

ℹ️ If your module includes a .json package, you need to add this command line for your module to function correctly

Expand All @@ -162,8 +162,8 @@ For your information ℹ️:

If you still can't install the module PR, you'll probably find some hint in its *readme*.

![img.png](images/readme20.png)
<img src="images/readme20.png" alt="img.png" class="mx-lg-4" style="max-width: 700px">

Click on the **branch** link then scroll down and you'll find an Installation section:

![img.png](images/readme21.png)
<img src="images/readme21.png" alt="img.png" class="mx-lg-4" style="max-width: 700px">
Original file line number Diff line number Diff line change
Expand Up @@ -18,19 +18,20 @@ To do this, simply :

1. Go to Prestashop Pull requests:

![Pull request](images/release_manager_img_1.png)
<img src="images/release_manager_img_1.png" alt="Pull request" class="mx-lg-4" style="max-width: 700px">

2. Click on Milestones

![Milestones](images/release_manager_img_2.png)
<img src="images/release_manager_img_2.png" alt="Milestones" class="mx-lg-4" style="max-width: 700px">

1. Click on the version you require (for this example, it will be 1.7.8.9)

![Version](images/release_manager_img_3.png)
3. Click on the version you require (for this example, it will be 1.7.8.9)

<img src="images/release_manager_img_3.png" alt="Version" class="mx-lg-4" style="max-width: 700px">

4. Click on Closed (these are the merged PRs for the selected version)

![Closed](images/release_manager_img_4.png)
<img src="images/release_manager_img_4.png" alt="Closed" class="mx-lg-4" style="max-width: 700px">

You now have the list of all the PRs merged in your release. It's highly recommended that you check them all to find out what these PRs might affect.

Expand All @@ -45,19 +46,19 @@ Again, we'll do this in a few steps:

1. Open [Prestashop project](https://build.prestashop-project.org/test-scenarios/)

![Tests](images/release_manager_img_19.png)

1. Select the various repository affected by the PRs (e.g. a change in product creation)
<img src="images/release_manager_img_19.png" alt="Closed" class="mx-lg-4" style="max-width: 700px">

![test repos](images/release_manager_img_20.png)
2. Select the various repository affected by the PRs (e.g. a change in product creation)

3. Once you've identified the different scenarios that interest you, write them down (or mark them in your notepad).
<img src="images/release_manager_img_20.png" alt="test repos" class="mx-lg-4" style="max-width: 700px">

![Tests2](images/release_manager_img_21.png)
3. Once you've identified the different scenarios that interest you, write them down (or mark them in your notepad).

<img src="images/release_manager_img_21.png" alt="Tests2" class="mx-lg-4" style="max-width: 700px">

If you've followed all these steps, you should now have your list of test scenarios which should be tested for this release, which you can share with your team members and developers.

All that's left for you to do now is carry out the various tests and, at the end of the day, share with the team, made up of PMs and Developers, if we've encountered any issues during our work.

Happy Release.
Happy Release.
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,9 @@ You can login into the virtual machine with `vagrant ssh`
If something went wrong during the installation, the error is displayed explaining which command is failing.

* Invalid branch name:
{{< figure src="img/vagrant/build-failed.png" alt="Invalid git branch name" >}}

<img src="img/vagrant/build-failed.png" alt="Invalid git branch name" class="mx-lg-4" style="max-width: 700px">

* Invalid PHP version:
{{< figure src="img/vagrant/invalid-php-version.png" alt="Invalid PHP version" >}}

<img src="img/vagrant/invalid-php-version.png" alt="Invalid PHP version" class="mx-lg-4" style="max-width: 700px">
Loading