Merge pull request #251 from v4lux/fix/patch-order

Handle response 204 status code (patch order)
PrestaShopCorp · Jan 9, 2020 · 15a5463 · 15a5463
2 parents 6f48327 + dc9658d
commit 15a5463
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/classes/Handler/Response/ResponseApiHandler.php b/classes/Handler/Response/ResponseApiHandler.php
@@ -63,6 +63,12 @@ public function handleResponse(ResponseInterface $response)
      */
     private function responseIsSuccessful($responseContents, $httpStatusCode)
     {
+        // Directly return true, no need to check the body for a 204 status code
+        // 204 status code is only send by /payments/order/update
+        if ($httpStatusCode === 204) {
+            return true;
+        }
+
         return substr((string) $httpStatusCode, 0, 1) === '2' && $responseContents !== null;
     }
 }