Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBO-1456] [MBO 2.4.x] Add tab for uninstalled modules in Module manager #689

Merged
merged 3 commits into from
Dec 14, 2023

Conversation

sowbiba
Copy link
Contributor

@sowbiba sowbiba commented Nov 26, 2023

image

image

Fix for #612

Copy link
Contributor

@intraordinaire intraordinaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just missing a translation, looking good otherwise
Bravo, and thanks !

@micka-fdz
Copy link

Hi @sowbiba, is this new tab only added for PS 1.7 ?

@sowbiba
Copy link
Contributor Author

sowbiba commented Nov 27, 2023

Hi @sowbiba, is this new tab only added for PS 1.7 ?

Hi @micka-fdz
On PS 8.0+, uninstalled modules appear in the Module Manager listing

@micka-fdz
Copy link

micka-fdz commented Nov 27, 2023

I know that @sowbiba, I'm just asking if this new tab is hidden on PS 8 to avoid double use.

@sowbiba
Copy link
Contributor Author

sowbiba commented Nov 27, 2023

I know that @sowbiba, I'm just asking if this new tab is hidden on PS 8 to avoid double use.

The PR target is 2.3.x

The new tab is indeed only for 1.7.6+ and < 8.0

@sowbiba sowbiba force-pushed the tab-uninstalled-modules branch from e298074 to da653ec Compare December 12, 2023 16:51
@sowbiba sowbiba changed the title Add tab for uninstalled modules in Module manager [MBO-1456] [MBO 2.4.x] Add tab for uninstalled modules in Module manager Dec 14, 2023
@sowbiba sowbiba changed the base branch from 2.3.x to 2.4.x December 14, 2023 16:23
@sowbiba sowbiba merged commit a0af585 into 2.4.x Dec 14, 2023
12 checks passed
@sowbiba sowbiba deleted the tab-uninstalled-modules branch December 14, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants