Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

102-XXXX Errors #9

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Conversation

Spletz47
Copy link

@Spletz47 Spletz47 commented Aug 7, 2024

Changes:

Adds additional 102-error information

Copy link
Member

@jonbarrow jonbarrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize for the delayed review, been very busy

"0001": {
"name": "MAIL_ADDRESS_NOT_CONFIRMED",
"message": "",
"short_description": "Unknown cause",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Period was removed?

"1001": {
"name": "ACCOUNT_NOT_FOUND",
"message": "Unable to find the specified user.",
"short_description": "The Nintendo/Pretendo Network ID entered was incorrect or does not exist.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a short description is being added, then a long one should also be added. The short fields are designed for use by the Discord bot. The long fields are used for the website. Only having one of them makes the data unavailable by the other.

You can see a good example of how to format these fields here https://github.com/PretendoNetwork/error-codes/blob/master/data/104/2210/en_US.json

This goes for all cases of this, as there are multiple in this PR

"message": "Use of this feature requires a linked\nNintendo Network ID.\n\nYou can link an ID from User Settings.",
"short_description": "Unknown cause.",
"long_description": "Unknown cause.",
"short_solution": "Link a Nintendo/Pretendo Network ID to your user.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a short solution is being added, then a long one should also be added. The short fields are designed for use by the Discord bot. The long fields are used for the website. Only having one of them makes the data unavailable by the other.

You can see a good example of how to format these fields here https://github.com/PretendoNetwork/error-codes/blob/master/data/104/2210/en_US.json

This goes for all cases of this, as there are multiple in this PR

"message": "The information entered is not correct.\nYou may have entered the ID of another\nservice.\n\nPlease enter the details again, making\nsure that the Nintendo Network ID,\npassword, and e-mail address are\ncorrect.",
"short_description": "Invalid account information provided. Either your username, password, or email address does not match",
"long_description": "Unknown cause.",
"short_solution": "Enter corrected information and try again. You might also not be connected to the wrong network for the respective account.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads as "wifi network", which is confusing. Should probably be reworded

Comment on lines 6 to 9
"short_description": "Your console is permanently banned from this game",
"long_description": "Unknown cause.",
"short_solution": "Don't do whatever you did to get banned",
"long_solution": "Unknown solution.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my fault not yours, but since you're changing these files anyway would you mind updating the long fields in cases like this? There's multiple of them

Comment on lines -1 to +12
{
"102": {
"0001": {
"name": "MAIL_ADDRESS_NOT_CONFIRMED",
"message": "",
"short_description": "Unknown cause.",
"long_description": "Unknown cause.",
"short_solution": "Unknown solution.",
"long_solution": "Unknown solution.",
"support_link": "https://preten.do/102-0001"
}
}
{
"102": {
"0001": {
"name": "MAIL_ADDRESS_NOT_CONFIRMED",
"message": "",
"short_description": "Unknown cause.",
"long_description": "Unknown cause.",
"short_solution": "Unknown solution.",
"long_solution": "Unknown solution.",
"support_link": "https://preten.do/102-0001"
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like you're changing the line endings of things? Please ensure you are not

"message": "The information entered is not correct.\nYou may have entered the ID of another\nservice.\n\nPlease enter the details again, making\nsure that the Nintendo Network ID,\npassword, and e-mail address are\ncorrect.",
"short_description": "Invalid account information provided. Either your username, password, or email address does not match.",
"long_description": "Invalid account information provided. Either your username, password, or email address does not match.",
"short_solution": "Enter the correct information and try again. You might also not be connected to Pretendo Network while trying to sign in with an NNID, or Nintendo Network while trying to sign in with a PNID.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"You might also not be connected to Pretendo Network while trying to sign in with an NNID" does not make sense. If you are not connected to Pretendo Network, then you are connected to Nintendo Network. Where using a NNID is expected

Also these short fields are getting very long. They should be as short as possible. For more detailed answers people should visit the support links

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants