Numpy2 fix #199
Merged
Numpy2 fix #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smiet
requested review from
landreman,
zhucaoxiang,
jonathanschilling and
abaillod
|
Merging with positive review from @jons-pf (github complains because your other account is the official contributor to spec, sorry for the doubled requests Jonathan, and thanks for the review!) |
|
My only recommendation is to convert the versioning scheme to an automatic one based on Git hashes such as setuptools_scm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numpy 2.0 breaks the binary interface to compiled code. And it is what is installed with 'pip install numpy'. Binaries compiled with numpy<2.0 cannot run with 2.0.
Therefore we need to upgrade the repo and binaries so it is installed with numpy2.0, but leaves the system numpy intact.
This PR does that, and is part of the numpy2.0 migration of simsopt (hiddenSymmetries/simsopt#427)
A speedy review would be appreciated, the changes are minor. The specific branch of f90wrap is also awaiting PR approval on upstream branch, so we might soon switch away from needing our private branch (jameskermode/f90wrap#194).
The edits to src/hesian.f90 are because the new f90wrap includes more meta-info in function docstrings, and LaTeX in python strings gives unexpected escape caracters.
Will merge with two approving reviews, tests are passing.