Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the instructions for compilation using cmake #203

Merged
merged 7 commits into from
Aug 7, 2024

Conversation

ErolBa
Copy link
Collaborator

@ErolBa ErolBa commented Jul 15, 2024

No description provided.

Copy link
Collaborator

@jons-pf jons-pf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for writing this up!

@smiet
Copy link
Collaborator

smiet commented Aug 7, 2024

Thanks Jonathan for the approval! I see your pf-account @jons-pf is not added as a collaborator to SPEC, only @jonathanschilling, but your pf account is your primary github account, I have given this account write privileges, but your previous account was admin. Would need admin rights? If so, LMK.

@smiet smiet merged commit fd2fd15 into master Aug 7, 2024
10 checks passed
@jons-pf
Copy link
Collaborator

jons-pf commented Aug 7, 2024

Thanks Jonathan for the approval! I see your pf-account @jons-pf is not added as a collaborator to SPEC, only @jonathanschilling, but your pf account is your primary github account, I have given this account write privileges, but your previous account was admin. Would need admin rights? If so, LMK.

Hi @smiet , thanks for catching this! My account related to Proxima Fusion is jons-pf and write priviledges are fine for me as of now. If and when I would get back to more SPEC-focused developments, admin rights might come in handy again, but let's postpone this until then, ok? :-)

@ErolBa ErolBa deleted the compile_instructions_update branch October 7, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants