Merge THRIFT_DKES_PENTA into develop #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazersos
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The integration
DKES+PENTA+THRIFTis fixed and ready to merge. There are still some features I'd like to add, but they are not very important so I will leave them for the future.To make sure the integration is correct, I have ran THRIFT with
bootstrap_type='dkespenta'. I ran THRIFT 1 time step which allows to obtain J_BS at t=0, which can then be compared with the result of running PENTA by itself:Note that J_BS from
DKES+PENTA+THRIFTis the result of an interpolation at THRIFT's grid, hence why the maxima and the minima. Nevertheless, the two curves agree at the input surfaces (which were set as the same when running THRIFT and PENTA).