Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more linux instructions and fix + add to flatpak inst. building #309

Merged
merged 45 commits into from
Jul 9, 2024

Conversation

LackingCats
Copy link
Contributor

Most of the popular linux distributions are already covered, however the niche ones should also be considered, and that is why I am making this pull request rn

Signed-off-by: Ascende Supirius <[email protected]>
@netlify
Copy link

netlify bot commented Jun 17, 2023

Deploy Preview for prismlauncher ready!

Name Link
🔨 Latest commit 5ce4a5f
🔍 Latest deploy log https://app.netlify.com/sites/prismlauncher/deploys/668d1c8594e938000886480f
😎 Deploy Preview https://deploy-preview-309--prismlauncher.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@LackingCats LackingCats marked this pull request as draft June 17, 2023 13:15
Signed-off-by: Ascende Supirius <[email protected]>
Signed-off-by: Ascende Supirius <[email protected]>
its all the same why are there so many may god help me

Signed-off-by: Ascende Supirius <[email protected]>
@LackingCats LackingCats marked this pull request as ready for review June 17, 2023 13:43
@LackingCats
Copy link
Contributor Author

all done, all linux versions as seen on repology now appear on the linux.md download page!

an oopsie i noticed - without --recursive, libusb and other shared modules would not get cloned, causing the build to fail

Signed-off-by: Ascende Supirius <[email protected]>
combine alt linux and aosc linux

Signed-off-by: Ascende Supirius <[email protected]>
add unmaintained notice

Signed-off-by: Ascende Supirius <[email protected]>
clarity (pls squash)

Signed-off-by: Ascende Supirius <[email protected]>
Signed-off-by: Ascende Supirius <[email protected]>
._.

Signed-off-by: Ascende Supirius <[email protected]>
changed https hardcode to local links
Signed-off-by: Ascende Supirius <[email protected]>
@LackingCats
Copy link
Contributor Author

pls squash thx

…ub repo so its fine ig, check the deploy preview

Signed-off-by: Ascende Supirius <[email protected]>
._.

Signed-off-by: Ascende Supirius <[email protected]>
Signed-off-by: Ascende Supirius <[email protected]>
pls squash

Signed-off-by: Ascende Supirius <[email protected]>
@LackingCats
Copy link
Contributor Author

i should be all done, lmk if any changes need to be made

@LackingCats LackingCats changed the title add more linux instructions add more linux instructions and fix + add to flatpak inst. building Jul 2, 2023
Signed-off-by: Ascende Supirius <[email protected]>
final commit i promisel also pls squash

Signed-off-by: Ascende Supirius <[email protected]>
src/download/linux.md Outdated Show resolved Hide resolved
src/download/linux.md Outdated Show resolved Hide resolved
src/download/linux.md Outdated Show resolved Hide resolved
src/download/linux.md Outdated Show resolved Hide resolved
src/wiki/development/build-instructions.md Outdated Show resolved Hide resolved
src/wiki/development/build-instructions.md Outdated Show resolved Hide resolved
src/wiki/development/build-instructions.md Outdated Show resolved Hide resolved
Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(oops, forgot to check "request changes")

awesome work! just a few things to iron out :)

Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides the comment, everything lgtm :)

src/download/linux.md Outdated Show resolved Hide resolved
@LackingCats
Copy link
Contributor Author

Ready 4 review (again again)

@ZekeZDev
Copy link
Member

ZekeZDev commented Oct 31, 2023

assigning myself to look through thoroughly on my holidays. Apologies for very late review

@ZekeZDev ZekeZDev self-assigned this Oct 31, 2023
Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LackingCats
Copy link
Contributor Author

ready for review (been a while huh)

@LackingCats
Copy link
Contributor Author

just syncing (pls no lint fail)

Signed-off-by: Ascende Supirius <[email protected]>
Signed-off-by: Ascende Supirius <[email protected]>
Signed-off-by: Ascende Supirius <[email protected]>
@LackingCats
Copy link
Contributor Author

ready for review

@LackingCats
Copy link
Contributor Author

once again ready for review

@LackingCats
Copy link
Contributor Author

also pls squash

@LackingCats
Copy link
Contributor Author

(i'm not very efficient with my commits)

@ZekeZDev ZekeZDev merged commit 483fc4b into PrismLauncher:main Jul 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants