Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error happen when allocate iluvatar device #522

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

lijm87
Copy link
Contributor

@lijm87 lijm87 commented Sep 29, 2024

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix: error 'index out of range [1] with length 1' happen when allocate iluvatar device
fix: exception occurred while creating multiple pods with iluvatar gpu concurrently

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@archlitchi
Copy link
Collaborator

thanks:) are you using iluvatar devices in HAMI?

@archlitchi
Copy link
Collaborator

/approve

@archlitchi
Copy link
Collaborator

please fix go-lint CI, so it can be integrated

@lijm87
Copy link
Contributor Author

lijm87 commented Oct 10, 2024

thanks:) are you using iluvatar devices in HAMI?

yes

@lijm87
Copy link
Contributor Author

lijm87 commented Oct 10, 2024

please fix go-lint CI, so it can be integrated

done

@wawa0210
Copy link
Member

@lijm87 We also need to reabse this PR into a single commit, ths last step 😄

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
unittests 28.30% <100.00%> (+0.68%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/device/iluvatar/device.go 31.89% <100.00%> (+13.47%) ⬆️

…e iluvatar device

fix: exception occurred while creating multiple pods with iluvatar gpu concurrently

Signed-off-by: junmin.li <[email protected]>
@lijm87
Copy link
Contributor Author

lijm87 commented Oct 15, 2024

@lijm87 We also need to reabse this PR into a single commit, ths last step 😄

done

@wawa0210 wawa0210 merged commit ddec252 into Project-HAMi:master Oct 15, 2024
7 checks passed
@wawa0210
Copy link
Member

@lijm87 thanks your contribution, nice job 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants