Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Mocha and Chai #62

Merged
merged 1 commit into from
Aug 2, 2016
Merged

Install Mocha and Chai #62

merged 1 commit into from
Aug 2, 2016

Conversation

ankitr
Copy link
Member

@ankitr ankitr commented Aug 2, 2016

Working toward #35. Now we can write Mocha tests with Chai asserts. (I'm a personal fan of expect style asserts.) PTAL @gmittal

@@ -33,10 +33,12 @@
"shelljs": "^0.7.0"
},
"devDependencies": {
"chai": "^3.5.0",
"eslint": "^3.2.0",
"eslint-config-airbnb": "^9.0.1",
"eslint-config-airbnb-base": "^5.0.1",
"eslint-plugin-import": "^1.12.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmmm... Delete and reinstall JSX (do we even need it?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was just a comma added at the end of the line. We do need it for eslint.

@gmittal
Copy link
Member

gmittal commented Aug 2, 2016

Sans-JSX plugin, LGTM

@ankitr ankitr merged commit dbf4d48 into master Aug 2, 2016
@ankitr ankitr deleted the install-mocha branch August 2, 2016 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants