#1872: fixes and adds tests

ProjectMirador · Feb 20, 2019 · 5ce995c · 5ce995c
1 parent 394263f
commit 5ce995c
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 18 deletions.
diff --git a/__tests__/src/components/WindowSideBarCanvasPanel.test.js b/__tests__/src/components/WindowSideBarCanvasPanel.test.js
@@ -3,61 +3,64 @@ import { shallow } from 'enzyme';
 import List from '@material-ui/core/List';
 import ListItem from '@material-ui/core/ListItem';
 import Typography from '@material-ui/core/Typography';
+import manifesto from 'manifesto.js';
 import WindowSideBarCanvasPanel from '../../../src/components/WindowSideBarCanvasPanel';
+import CanvasThumbnail from '../../../src/components/CanvasThumbnail';
+import manifestJson from '../../fixtures/version-2/019.json';
+import { getIdAndLabelOfCanvases } from '../../../src/state/selectors';
 
 describe('WindowSideBarCanvasPanel', () => {
   let wrapper;
   let setCanvas;
-  const canvasesIdAndLabel = [
-    {
-      id: 'testid1',
-      label: 'testLabel',
-    },
-    {
-      id: 'testid2',
-      label: 'testLabel2',
-    },
-  ];
+  let canvases;
 
   beforeEach(() => {
     setCanvas = jest.fn();
+    canvases = manifesto.create(manifestJson).getSequences()[0].getCanvases();
 
     wrapper = shallow(
       <WindowSideBarCanvasPanel
-        canvasesIdAndLabel={canvasesIdAndLabel}
+        canvases={canvases}
         classes={{}}
         t={key => key}
         windowId="xyz"
         setCanvas={setCanvas}
+        config={{ canvasNavigation: { height: 100 } }}
       />,
     ).dive();
   });
 
   it('renders all needed elements', () => {
     expect(wrapper.find(Typography).at(0).render().text()).toBe('canvasIndex');
     expect(wrapper.find(List).length).toBe(1);
-    expect(wrapper.find(ListItem).length).toBe(canvasesIdAndLabel.length);
-    expect(wrapper.find(List).find(Typography).length).toBe(canvasesIdAndLabel.length);
+    expect(wrapper.find(ListItem).length).toBe(3);
+    expect(wrapper.find(List).find(Typography).length).toBe(3);
   });
 
   it('should set the correct labels', () => {
+    const idsAndLabels = getIdAndLabelOfCanvases(canvases);
     expect(wrapper
       .find(List)
       .find(Typography)
       .at(0)
       .render()
-      .text()).toBe(canvasesIdAndLabel[0].label);
+      .text()).toBe(idsAndLabels[0].label);
 
     expect(wrapper
       .find(List)
       .find(Typography)
-      .at(1)
+      .at(0)
       .render()
-      .text()).toBe(canvasesIdAndLabel[1].label);
+      .text()).toBe(idsAndLabels[1].label);
   });
 
-  it('should call the onClick handler', () => {
+  it('should call the onClick handler of a navigation item\'s label', () => {
     wrapper.find(Typography).at(1).simulate('click');
     expect(setCanvas).toHaveBeenCalledTimes(1);
   });
+
+  it('should call the onClick handler of a navigation item\'s thumbnail', () => {
+    wrapper.find(CanvasThumbnail).at(0).simulate('click');
+    expect(setCanvas).toHaveBeenCalledTimes(1);
+  });
 });
diff --git a/src/components/WindowSideBarInfoPanel.js b/src/components/WindowSideBarInfoPanel.js
@@ -51,7 +51,6 @@ WindowSideBarInfoPanel.propTypes = {
   t: PropTypes.func,
 };
 
-
 WindowSideBarInfoPanel.defaultProps = {
   canvasDescription: null,
   canvasLabel: null,