Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CanvasNavigation Panel --> Thumbnail list #1872

Closed
3 tasks done
camillevilla opened this issue Feb 13, 2019 · 1 comment
Closed
3 tasks done

CanvasNavigation Panel --> Thumbnail list #1872

camillevilla opened this issue Feb 13, 2019 · 1 comment
Assignees
@glefi

Comments

@camillevilla
Copy link
Member

camillevilla commented Feb 13, 2019 •
edited by mejackreed
Loading

See #1584 and #1772

screen shot 2019-02-12 at 8 33 17 pm

Acceptance Criteria

  • canvas thumbnails are lazy loaded (something similar to thumbnail nav)
  • canvas label is rendered
  • Clicking on thumbnail or title changes canvasIndex

Out of Scope

  • annotation, layer icons
  • Other canvas navigation menu options

screen shot 2019-02-12 at 8 33 07 pm

Resources
@glefi glefi self-assigned this Feb 19, 2019
glefi added a commit that referenced this issue Feb 20, 2019
@glefi
#1872 add thumbnails to canvas navigation
c73c5a4
glefi added a commit that referenced this issue Feb 20, 2019
@glefi
#1872 add clickHandler to canvas navigation label
394263f
glefi added a commit that referenced this issue Feb 20, 2019
@glefi
#1872: fixes and adds tests
5ce995c
glefi added a commit that referenced this issue Feb 20, 2019
@glefi
#1872: fixes tests
9ca7ed4
glefi added a commit that referenced this issue Feb 20, 2019
@glefi
#1872: fix issue with aspect ratio for chrome
44e23ba
glefi added a commit that referenced this issue Feb 21, 2019
@glefi
#1872 add thumbnails to canvas navigation
6dba8b2
glefi added a commit that referenced this issue Feb 21, 2019
@glefi
#1872 add clickHandler to canvas navigation label
2c5f779
glefi added a commit that referenced this issue Feb 21, 2019
@glefi
#1872: fixes and adds tests
6728896
glefi added a commit that referenced this issue Feb 21, 2019
@glefi
#1872: fixes tests
9b98b7e
glefi added a commit that referenced this issue Feb 21, 2019
@glefi
#1872: fix issue with aspect ratio for chrome
378965f
glefi added a commit that referenced this issue Feb 21, 2019
@glefi
#1872 add thumbnails to canvas navigation
6082ef9
glefi added a commit that referenced this issue Feb 21, 2019
@glefi
#1872: fix tests
a607d61
glefi added a commit that referenced this issue Feb 21, 2019
@glefi
#1872: fixes lazy loading for canvas thumbnail navigation
83d9de5
mejackreed added a commit that referenced this issue Feb 21, 2019
@mejackreed
Merge pull request #1940 from ProjectMirador/1872-thumbnail-list
ed2bc3d 
#1872: fixes lazy loading for canvas thumbnail navigation
@mejackreed
Copy link
Collaborator

Resolved in #1940 and #1937

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glefi glefi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mejackreed @camillevilla @glefi