splits core and app into separate packages, adds complete configuration for dev and production #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes ProjectMirador#66 adds ejected create react app configuration to app moves tests to subdirectories of components linting changes closes ProjectMirador#68 handles prop updates in Window replaces binds with arrow functions excludes console in eslint adds build to .gitignore adds lerna.json
christopher-johnson
force-pushed
the
history
branch
5 times, most recently
from
e8143f1
to
6e4b807
Compare
adds coverage reports replaces .babelrc with package.json config in core adds new travis build
christopher-johnson
force-pushed
the
history
branch
from
6e4b807
to
9add11e
Compare
adds mirador3-e2e-tests package
christopher-johnson
force-pushed
the
history
branch
from
3e56ceb
to
6d870fd
Compare
|
Thanks for modifying and resubmitting. I think it will be good to discuss this in person and perhaps in a larger group. Are you coming the working meeting in Edinburgh? |
|
yes. I will be there. Look forward to discussing this then. |
|
Excellent! |
refactors common components into common package adds minimal app build to e2e tests and removes dist binary
christopher-johnson
force-pushed
the
history
branch
5 times, most recently
from
6253c86
to
b10bb41
Compare
christopher-johnson
force-pushed
the
history
branch
5 times, most recently
from
542c435
to
0b313c5
Compare
adds unit test shell for unconnected App
christopher-johnson
force-pushed
the
history
branch
3 times, most recently
from
3ae4bcf
to
75de719
Compare
christopher-johnson
force-pushed
the
history
branch
4 times, most recently
from
dd568ff
to
eccfc1e
Compare
use app lib for e2e tests
christopher-johnson
force-pushed
the
history
branch
from
eccfc1e
to
694885b
Compare
christopher-johnson
force-pushed
the
history
branch
from
36a0c4e
to
5d692a0
Compare
|
I close this per discussion in #66 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This structure provides a basis for extensible "package oriented" component design and testing with a development server and environment and also a production deployment of mirador app. There are many, many options with webpack, so this should not be considered complete, but does provide reasonable defaults for further enhancement.
The separation of versioned libraries and feature/plugin components from the main app allows maintainability as the code-base grows. Currently, there is one library,
mirador3-corewhich provides redux actions and reducers.As a library then,
mirador3-coreis just a npm package and can be published by itself. Currently, since it is not published, it is referenced in the package.json with "file://"The option in
minimal_redux_pocto provide a distribution binary ofmirador3-appfor an non-optimized production app build is also be provided and can be created by runningnpm run dist. Note that production deployment with webpack primarily involves chunking, and this cannot be achieved with a distribution binary. Chunking optimizations are particularly advantageous for mobile platforms.The procedure from a fresh clone of the repo is install, build dep packages (i.e. core, etc.), and run. See the
.travis.ymlfile for the process. Until core is published, installing locally referenced packages must be done from each package root. If all deps packages are published thenlerna bootstrapcan be used from root to install.After install, then
lerna run buildcan be run from root which builds everything and thenlerna run startto start the app.This is a resubmission that moves src files from
mirador_redux_pocto retain history. That directory is now empty of source except for two IT tests.See #67 for previous submission review comments.
An integration testing package that uses Cypress has also been created in
packages/mirador3-e2e-tests. This currently depends on the distribution binary, but offers an extensible configuration to support multiple app builds from imports using a published artifact with webpack.