Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set allow_errors: False #6

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Set allow_errors: False #6

merged 1 commit into from
Dec 6, 2022

Conversation

brian-rose
Copy link
Member

Consistent with the latest Template ProjectPythia/cookbook-template#98

@github-actions
Copy link

github-actions bot commented Dec 2, 2022

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: 0b6aa6d
✅ Deployment Preview URL: https://ProjectPythia.github.io/gridding-cookbook/_preview/6

@brian-rose
Copy link
Member Author

Still no previews for this repo. I just opened #7.

@brian-rose
Copy link
Member Author

Addresses ProjectPythia/cookbook-template#53

@brian-rose
Copy link
Member Author

The preview is now visible at
https://projectpythia.org/gridding-cookbook/_preview/6

@brian-rose
Copy link
Member Author

Looks good but there is a runtime error triggered by this line:

area_def, cf_info = load_cf_area('data/onestorm.nc', variable='visible', x='x', y='y')

in this section: https://projectpythia.org/gridding-cookbook/_preview/6/notebooks/pyresample_intro.html#loading-in-one-netcdf

It's not clear to me why the CI test passed given the runtime error.

@brian-rose
Copy link
Member Author

But I think it would be useful to merge this PR now and pursue further testing.

@brian-rose brian-rose merged commit db021ef into main Dec 6, 2022
@brian-rose brian-rose deleted the brian-rose-patch-1 branch December 6, 2022 19:36
github-actions bot pushed a commit that referenced this pull request Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant