Do not allow untagged cell execution failures #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically built with GitHub Actions and Netlify. To see the status of your deployment, click below. 🔍 Git commit SHA: 4a5379b |
brian-rose
requested review from
andersy005 and
mgrover1
and removed request for
a team
dopplershift
approved these changes
Nov 28, 2022
clyne
approved these changes
Nov 28, 2022
dcamron
approved these changes
Nov 28, 2022
brian-rose
added a commit
to brian-rose/pythia-foundations
that referenced
this pull request
Jan 26, 2023
* Fix mamba version in all actions * unpin mamba * Do not allow untagged cell errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #345
All cells in Foundations notebooks that are expected to fail already have the
raises-exceptioncell tag.This PR sets
allow_errors: Falsein the config file to actually enforce this rule and catch any non-tagged execution failures.